[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> wrote:
>  --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> > Dear diary, on Thu, Dec 20, 2001 at 03:56:35PM CET, I got a letter,
> [...]
> > > > +  /* Usage of (happy && bored) led to a lack of foresight,
> > especially
> > > > +   * re: Chapel -- Syela */
> > > > +  while (happy) { happy--; happy += SADVAL; }
> > >                              ^^^^^^^^
> > > surely you mean value here ;)
> > Ouch. I don't get it, but my autogame tests just *didn't* catch that. 
> 
> this is suspicious.
> maybe try and put assert(!happy) here?
> 
> > And funny that even both Raahul and Ross didn't notice it as well.
> 
> pah I am just so much better reviewer ;)
> 

Modest too. Actually, that was good work on finding that. Perhaps you
should consider the maintainer's lifestyle. As Raimar will testify,
it's all fast cars and faster women ;).

> > 
> > > In general the patch is very good and I can only pity it's sad fate.
> > Ehm? What? Sad fate?! ;)
> > 
> 
> I have a bad premonition about your patch...
> I have a bad premonition about a lot of other good and useful patches
> too...
>

It's nice to see you have developed pyschic powers. I was going to ask
you a question, but you're already going to send me the right answer
anyway. 


__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com