Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2001:
[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)
Home

[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Raahul Kumar <raahul_da_man@xxxxxxxxx>
Cc: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)
From: Petr Baudis <pasky@xxxxxxxxxxx>
Date: Fri, 21 Dec 2001 14:44:38 +0100

Dear diary, on Fri, Dec 21, 2001 at 12:41:32PM CET, I got a letter,
where Raahul Kumar <raahul_da_man@xxxxxxxxx> told me, that...
> > > > +  /* If units are making us unhappy, count that too. */
> > > > +  sad += pcity->ppl_unhappy[3] - pcity->ppl_unhappy[2];
> > > > +  /* Angry citizens has to be counted double!? */
> > > 
> > > they _have_ to be counted double
> > Hey, this was in original source too! ;))
>
> I think that is a bad comment. Maybe something like One angry citizens is
> equal to two unhappy citizen, because an angry citizen has to be made
> unhappy, then he can be made content. The man is a ticking time bomb.
That makes sense. Updated patch attached :).

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
.
  "A common mistake that people make, when trying to design
   something completely foolproof is to underestimate the
   ingenuity of complete fools."
     -- Douglas Adams in Mostly Harmless
.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/

Attachment: advdomestic.c.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]