[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Petr Baudis <pasky@xxxxxxxxxxx> wrote:


>   I think it's ready to actually go in. If someone has some objections, he
> should speak now or stay silent forever ;).
> 

Some minor nitpicks.


> -  return 0;
> +    }
> +  } city_map_iterate_end;
> +  
> +  return best;
>  }
>

The original function had a return 0. You got rid of it. I believe you have
tested it and found it does not matter?
  
> -static int building_value(int max, struct city *pcity, int val)
> +/**************************************************************************
> +How much valuable the building would be for keeping of the city in order?
> +

Rephrase it as, 
The value of the building for keeping the city orderly.



I wish someone would speak up as to why 16 is a good number for sad value.
> +#define SADVAL 16
>

> +/**************************************************************************
> +Return a weighted value for a city's Ocean tiles
> +(i.e. based on the total number and number actively worked).
> +**************************************************************************/
>  static int ocean_workers(struct city *pcity)

Formatting changes only.




> -static int pollution_cost(struct player *pplayer, struct city *pcity,
> -                       Impr_Type_id id)
> +/**************************************************************************
> +Pollution benefit or cost of given improvement.
> +
> +Positive return value: less pollution if this improvement would be built
> +Negative return value: more pollution if this improvement would be built
> +Higher distance from zero means higher effect, naturally.
> +**************************************************************************/

Good comemnts. I like the work you put in here.




__________________________________________________
Do You Yahoo!?
Check out Yahoo! Shopping and Yahoo! Auctions for all of
your unique holiday gifts! Buy at http://shopping.yahoo.com
or bid at http://auctions.yahoo.com