[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Petr Baudis <pasky@xxxxxxxxxxx> wrote:

> > > +  /* If units are making us unhappy, count that too. */
> > > +  sad += pcity->ppl_unhappy[3] - pcity->ppl_unhappy[2];
> > > +  /* Angry citizens has to be counted double!? */
> > 
> > they _have_ to be counted double
> Hey, this was in original source too! ;))
>

I think that is a bad comment. Maybe something like 
One angry citizens is equal to two unhappy citizen, because an angry
citizen has to be made unhappy, then he can be made content. The man
is a ticking time bomb.
 
<snip>
> > > +  while (happy) { happy--; happy += SADVAL; }
> >                              ^^^^^^^^
> > surely you mean value here ;)
> Ouch. I don't get it, but my autogame tests just *didn't* catch that.  And
> funny that even both Raahul and Ross didn't notice it as well. Coincidence
> can
> be really evil.

Sigh. I admit I did not notice that. I am being appropiately punished
for my sins by a georgeous blonde with a whip. Good save there G.






__________________________________________________
Do You Yahoo!?
Check out Yahoo! Shopping and Yahoo! Auctions for all of
your unique holiday gifts! Buy at http://shopping.yahoo.com
or bid at http://auctions.yahoo.com