[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> Dear diary, on Thu, Dec 20, 2001 at 03:56:35PM CET, I got a letter,
[...]
> > > +  /* Usage of (happy && bored) led to a lack of foresight,
> especially
> > > +   * re: Chapel -- Syela */
> > > +  while (happy) { happy--; happy += SADVAL; }
> >                              ^^^^^^^^
> > surely you mean value here ;)
> Ouch. I don't get it, but my autogame tests just *didn't* catch that. 

this is suspicious.
maybe try and put assert(!happy) here?

> And funny that even both Raahul and Ross didn't notice it as well.

pah I am just so much better reviewer ;)

> 
> > In general the patch is very good and I can only pity it's sad fate.
> Ehm? What? Sad fate?! ;)
> 

I have a bad premonition about your patch...
I have a bad premonition about a lot of other good and useful patches
too...

G.


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com