[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> Dear diary, on Fri, Dec 21, 2001 at 05:08:29PM CET, I got a letter,
> where Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> told me, that...
> > 
> > this is suspicious.
> > maybe try and put assert(!happy) here?
> We shouldn't. It's not a requirement. When (!happy), you just actually
> drained whole effect of the building.

I meant put an assert, run a few games and see if it ever fails.
of course it's not a requirement, just a testing assert.
you can do it in gdb too of course

> > > > In general the patch is very good and I can only pity it's sad
> fate.
> > > Ehm? What? Sad fate?! ;)
> > > 
> > 
> > I have a bad premonition about your patch...
> I want to get it into official CVS and if it will be possible I hope I
> will get
> it there :). I just don't see anything controversial on it (hey, I even
> try to
> abide coding rules), I see sufficient (for me) feedback for it, so
> what? 

we will see.
I personally think that your patch has everything: it is useful, it got
+ve reviews, it even abides coding rules.  But it doesn't seem to be
sufficient here.

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com