[Freeciv-Dev] Re: Criticism

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx> wrote:
> 
> Choice want is 
>  < 0   an error, with a few hack-ceptions like (-199 == get_a_boat)
> == 0   no want, nothing to do
> <= 100 normal want
>  > 100 critical want, used to requisition emergency needs
>  > ??? probably an error (1024 is a reasonable upper bound)
> 

This want is -199. Can you tell me more? I thought if the want > 100 we tended
to reset it to 100. Is this commented anywhere in the code? If not, would you
mind
sending a patch to do so. 


> Cheers
> RossW
> =====
> 
> At 05:38 PM 01/12/06 -0800, Raahul Kumar wrote:
> >Just been reading advdomestic.c. 
> >
> > /* if (choice->want > 100) choice->want = 100; */         /* want > 100
> means
> >BUY RIGHT NOW */
> >
> > /* FIXME: rather (choice->want <= 0) --rwetmore */
> >
> >I do not like either change. Elsewhere in the ai code it claims
> choice-want is
> >in the range 0-100. I realise in fact that is actually not the case. I'd
> like
> >it if
> >you would actually make the change so that it is in the range 0-100.
> >
> >__________________________________________________
> >Do You Yahoo!?
> >Send your FREE holiday greetings online!
> >http://greetings.yahoo.com
> 
> 


__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com