[Freeciv-Dev] Re: Criticism

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Petr Baudis <pasky@xxxxxxxxxxx> wrote:
> Dear diary, on Fri, Dec 07, 2001 at 02:38:40AM CET, I got a letter,
> where Raahul Kumar <raahul_da_man@xxxxxxxxx> told me, that...
> > Just been reading advdomestic.c. 
> > 
> >  /* if (choice->want > 100) choice->want = 100; */         /* want > 100
> means
> > BUY RIGHT NOW */
> > 
> >  /* FIXME: rather (choice->want <= 0) --rwetmore */
> > 
> > I do not like either change. Elsewhere in the ai code it claims choice-want
> > is in the range 0-100. I realise in fact that is actually not the case. I'd
> > like it if you would actually make the change so that it is in the range
> > 0-100.
> This was commented before as well. Sorry, but really no behaviour changes in
> AI for now. And now I believe that:
> /* allowing buy of peaceful units after much testing -- Syela */
> is related to that.
> 
> Testing for choice.want will be probably in separate patch, as there are
> more places where this should be corrected (see Ross' corecleanup patch).
> 

Yes. 

__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com