[Freeciv-Dev] Re: freeciv2 kernel,modules and rulesets

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Mon, Dec 03, 2001 at 04:53:11PM CET, I got a letter,
where Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> On Mon, Dec 03, 2001 at 04:36:15PM +0100, Petr Baudis wrote:
> > Dear diary, on Mon, Dec 03, 2001 at 03:48:04PM CET, I got a letter,
> > where Andrew Sutton <ansutton@xxxxxxx> told me, that...
> > > On Monday 03 December 2001 09:44 am, Raimar Falke wrote:
> > > > Only one comment: the code has to be audited/changed for use of maps
> > > > larger than 255x255.
> > > 
> > > what do you mean? i'm not sure i follow...
> > unsigned char? anyway, the code shouldn use int for coords strictly, but
> > using char in three lines of current 92450 would be no wonder with the
> > actual state of the code ;-).
> 
> $ grep uint8 common/packets.c|grep -- '->y'|wc -l
>      18
> 
> $ grep -Irn 'char x' .
> ./server/gotohand.c:35:  unsigned char x, y;
pfff... ;)

obviously. you must multiple that with MAGIC_NUMBER_NOONE_KNOWS_WHAT_REPRESENTS
which is #define'd as 6, and 1 is aifuzzy() which happened to be actually zero
for me, just no luck :).

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
.
  "A common mistake that people make, when trying to design
   something completely foolproof is to underestimate the
   ingenuity of complete fools."
     -- Douglas Adams in Mostly Harmless
.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/