Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: PATCH: map iteration (PR#1018)
Home

[Freeciv-Dev] Re: PATCH: map iteration (PR#1018)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: PATCH: map iteration (PR#1018)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 23 Nov 2001 18:39:06 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sun, Nov 11, 2001 at 03:36:44PM +0100, Raimar Falke wrote:
> On Tue, Oct 30, 2001 at 05:17:03AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> > jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> 
> > +      printf(type, regular_map_pos_is_normal(x, y) ? (map_char_expr) : ' 
> > ');  \
>                                                                           ^^^
> This will only work if type is "%c".
> 
> > -     printf ("%X", pcmap->claims[map_inx(x,y)].whom);
> > +  WRITE_MAP_DATA("%X", pcmap->claims[map_inx(x,y)].whom);
> 
> This will print "20" which has a size of 2 and will destroy the
> format. This is a bug in the old code.
> 
> An updated patch is attached. Comments?

Applied. However I found one bug. Can anybody tell me which one?

        Raimar, today in quiz-master mood

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I heard if you play the NT-4.0-CD backwards, you get a satanic message."
 "That's nothing, if you play it forward, it installs NT-4.0"


[Prev in Thread] Current Thread [Next in Thread]