[Freeciv-Dev] Re: PATCH: map iteration (PR#1018)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Raimar Falke wrote:
> 
> On Tue, Oct 30, 2001 at 05:17:03AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> > jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> 
> > +      printf(type, regular_map_pos_is_normal(x, y) ? (map_char_expr) : ' 
> > ');  \
>                                                                           ^^^
> This will only work if type is "%c".
> 
> > -       printf ("%X", pcmap->claims[map_inx(x,y)].whom);
> > +  WRITE_MAP_DATA("%X", pcmap->claims[map_inx(x,y)].whom);
> 
> This will print "20" which has a size of 2 and will destroy the
> format. This is a bug in the old code.
> 
> An updated patch is attached. Comments?

The changes look good to me.  I do not think Ross likes this patch,
though.

jason