[Freeciv-Dev] Re: PATCH: map iteration (PR#1018)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 30, 2001 at 05:17:03AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:

> +      printf(type, regular_map_pos_is_normal(x, y) ? (map_char_expr) : ' '); 
>  \
                                                                          ^^^
This will only work if type is "%c".

> -       printf ("%X", pcmap->claims[map_inx(x,y)].whom);
> +  WRITE_MAP_DATA("%X", pcmap->claims[map_inx(x,y)].whom);

This will print "20" which has a size of 2 and will destroy the
format. This is a bug in the old code.

An updated patch is attached. Comments?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "How about the new language C&? No, that's not 'c ampersand', 'c reference', 
  'reference to c' or 'c and'. It's pronounced 'campersand', to confuse the 
  hell out of people who are unfamiliar with it, and it will, of course, 
  have no pointers."
    -- Xazziri in comp.lang.c++ about C#

map_iterate2.diff
Description: Text document