[Freeciv-Dev] Re: Server Overhaul (was Re: Re: Split patch)

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-10-22 13:20:37, Raimar Falke wrote:
> On Fri, Oct 19, 2001 at 06:40:21PM -0400, Justin Moore wrote:
> > 
> > > A description what should go into commands, serverio and settings and
> > > what shouldn't go would be nice.
> > 
> >    Done.
> > 
> > > Otherwise I wait for the patches to comment on them.
> > 
> >    In incoming/Server-Cleanup-new.tar.gz (has an extra patch on the end).
> 
> It looks like a huge amount of the changes you made are code moving. I
> think that such code movements provides no real benefit.

If it makes it easier to get a handle on things I think that is a very
real benefit...

> For example
> it may turn out that the partition into settings and commands is
> useless/wrong because the unification needs another partition of the
> code.

Perhaps... But I don't think that would be a disaster...
If the patch is good enough it's worth the risk... I'll have to take a
closer look to determine this...

> I'm not sure what you have "really" changed. Can you make a
> patch which just contains these changes?
> 
> I may change my opinion about the mode moving if you find interceders
> (people which agree that this is good) for this idea.

Well, it might need to mature a little but I don't think it's a bad
idea...

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)