[Freeciv-Dev] Re: refresh_tile_mapcanvas unification (PR#1026)

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Raimar Falke wrote:
> 
> On Sun, Oct 21, 2001 at 10:59:44PM -0700, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> > The attached patch attempts to unify the refresh_tile_mapcanvas function
> > for all GUI's.
> >
> > It has been tested for GTK, and I'm about to test it for Xaw.
> >
> > There are only three debatable points:
> >
> > - New files called client/mapview_common.[ch] are created.  Are these
> > names acceptable?
> 
> Yes for me.
> 
> > - The BeOS client will be disrupted by this change.  OTOH, the
> > applicable part of the BeOS client hasn't even been written yet so this
> > shouldn't really be a step backwards.
> 
> I would say: don't touch it.

That would take some cleverness; since mapview_common.c is built along
with the rest of the code you'll get a duplicate function error upon
compiling.  I think removing the function will make it easier to write
the BeOS client in the long run since all that's really there now is a
stub.

OTOH, leaving the BeOS client as-is to generate the error will cause the
next person to compile it to see the error and fix it.  Most likely
they'll just do what I did, but possibly not.

> > In summary, it would be ideal if GUI authors would verify and approve of
> > this patch.  Failing that, it would be nice if someone could at least
> > compile it for every GUI (if that works, the rest should too).
> >
> > (Note: the patch couldn't be made with cvs diff since new files are
> > created.  Apply with patch -p1 and be sure to run automake before
> > compilation.)
> 
> Can you also move other code to mapview_common? Like get_grid_color
> and concat_tile_activity_text?

Yes, but I'd rather do it one piece at a time.

jason