[Freeciv-Dev] Re: refresh_tile_mapcanvas unification (PR#1026)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Oct 21, 2001 at 10:59:44PM -0700, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> The attached patch attempts to unify the refresh_tile_mapcanvas function
> for all GUI's.
> 
> It has been tested for GTK, and I'm about to test it for Xaw.
> 
> There are only three debatable points:
> 
> - New files called client/mapview_common.[ch] are created.  Are these
> names acceptable?

Yes for me.

> - The BeOS client will be disrupted by this change.  OTOH, the
> applicable part of the BeOS client hasn't even been written yet so this
> shouldn't really be a step backwards.

I would say: don't touch it.

> - I've #included mapview_common.h from mapview_g.h.  This made it easy
> for me to make sure every relevant file had already included
> mapview_common.h.  The other alternative is to #include mapview_common.h
> from every file that uses refresh_tile_mapcanvas - but since I can't
> compile the code for many of the GUI's this is difficult to verify.

The way you done it is sane.

> In summary, it would be ideal if GUI authors would verify and approve of
> this patch.  Failing that, it would be nice if someone could at least
> compile it for every GUI (if that works, the rest should too).
> 
> (Note: the patch couldn't be made with cvs diff since new files are
> created.  Apply with patch -p1 and be sure to run automake before
> compilation.)

Can you also move other code to mapview_common? Like get_grid_color
and concat_tile_activity_text?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Q:  Do you know what the death rate around here is?
 A:  One per person.