[Freeciv-Dev] Re: [PATCH] flags_in_front (PR#1014)

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-10-19 16:10:40, Raimar Falke wrote:
> On Fri, Oct 19, 2001 at 03:59:17PM +0200, Daniel Sjölie wrote:
> > On 2001-10-19 15:46:22, Raimar Falke wrote:
> > > On Fri, Oct 19, 2001 at 01:34:34PM +0200, Daniel Sjölie wrote:
> > > > On 2001-10-19 12:18:41, Raimar Falke wrote:
> > > > > On Wed, Oct 17, 2001 at 09:40:10PM +0200, Daniel Sjölie wrote:
> > > > > > 
> > > > > > Comments on this please...
> > > > > 
> > > > > I had the hope that somebody besides me would comment on this. My
> > > > > opinion: technically ok, the patch is useful for *_shield tilesets. So
> > > > > I see no reason to not apply it. My only question is: what are
> > > > > data/misc/chiefs_front.spec and data/misc/shields_front.spec for?
> > > > 
> > > > Well, they position these graphics in a way that makes more sense when
> > > > they are in front (but would be hidden otherwise)...
> > > > See http://www.acc.umu.se/~deepone/freeciv/flags_in_front.png
> > > > 
> > > > Using the existing chiefs.spec and shields.spec would put the shield way
> > > > up the corner which looked really bad with the tileset used (should be
> > > > same effect at least with highres) since it's so small... It was really
> > > > confusing since the shield more or less ended up on another tile than
> > > > the unit...
> > > > 
> > > > It's possible these files don't work very well with other tilesets but
> > > > if so they could be modified... I certainly think you should be able to
> > > > place the shield in a sensible way (without breaking other tilesets
> > > > by changing existing chiefs.spec and shields.spec) easily...
> > > > 
> > > > That's what those files are there for...
> > > 
> > > But they aren't used in the patch you posted even if flaflags_in_front
> > > is set to 1. Or are they used?
> > 
> > Actually, I don't think flags_in_front is set i 1 anywhere in the
> > patch... :)
> 
> I set it to see what changed.
> 
> > I used it in combination with the civ2gxf tileset... I
> > posted a tilespec file for that tileset that did set flags_in_front to 1
> > and that file did use the files discussed above...
> > 
> > So, the actual patch as is should change nothing directly in freeciv...
> > It only makes it possible to do this easily...
> > 
> > I could post tilespec files for different tilesets actually using this
> > feature is that's desired but I don't think the lack of such files is a
> > hindrance to applying the patch... Small patches are good, right? :)
> 
> The patch doesn't change the behavior. If flags_in_front is set to one
> the files data/misc/chiefs_front.spec and data/misc/shields_front.spec
> aren't used. These files will only be used if another tileset uses
> them. Correct till here?

Well, yes... But I don't know really what you mean by "another"
tileset... The files needs to be used in _a_ tileset... I.e. in a
tilespec file...

> Why don't you bundle chiefs_front.spec and shields_front.spec with the
> new tileset (for example civ2gfx)? Why has these two files be included
> in the normal CVS tree?

There is no new tileset...
The civ2gfx is generated by a script posted to this list from civ2
graphics file... But even so the files we're talking about doesn't
belong to any tileset really... That's why they're in the misc dir...
And that's why the new ones should be in the normal CVS tree... They can
be used in any tileset (with the same dimensions?) to position the gfx
representing shields, health and such that doesn't really belong to a
specific tileset in a way suited for when having shields and such in
front...

So, if you're doing tests with flags_in_front set to 1 then you should
also replace chiefs.spec with chiefs_front.spec (and same with shields)
to get the result I'm after... This should not be done automatically when
flags_in_front is set to 1 - that's wouldn't be flexible...

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)