[Freeciv-Dev] Re: [PATCH] flags_in_front2

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Oct 20, 2001 at 12:54:53AM +0200, Daniel Sjölie wrote:
> On 2001-10-19 23:18:49, Raimar Falke wrote:
> > > > Is it possible to make and include a
> > > > {engels,trident}_shields_front.tilespec? This would make this
> > > > connection between the flat and the modified chiefs_front.spec and
> > > > shields_front.spec explicit.
> > > 
> > > Mmm... 
> > > But as I think about this I realize it's really quite ugly...
> > > What I'm doing with the *_front.spec files is shanging where the gfx
> > > will be drawn... That is, I only change x_top_left and y_top_left...
> > > When you consider making this for several tilesets of different
> > > dimensions you realize that you would need new spec files for each
> > > "dimension set" whit only two values changed... That's really ugly...
> > > 
> > > So, how can we do this better? Can it be done in another way as it is?
> > > Ideally I would set an offset for a spec file in the tilespec file...
> > > Is this possible? Any other way to do this right?
> > > I'll take a look at the (tile)spec code and see what I can do...
> > > 
> > > My initial thought is to make it possible to write something like:
> > > files = 
> > >   .....
> > >   "misc/chiefs.spec@32,25",
> > >   "misc/shields.spec@32,25"
> > > 
> > > to set offset of everything loaded from a spec file in the tilespec
> > > file... That would solve the problem in a much nicer way... IMHO...
> > > 
> > > What do you think?
> > 
> > What about two extra attributes (like flags_in_front)
> > flag_offset_[xy]? I think that the @ syntax is overkill.
> 
> Hmm... Overkill in what way? :)
> I went and did this so... If you meant it would be overkill to
> implement then that's not an issue anymore... :)

What is wrong with two extra attributes in the trident.tilespec? They
would used in the normal way. This special case with "...@x,y" is a
hack. I'm pretty sure that I will not allow it.

> I included example tilespec files for engels and highres, trident was
> too small for it to be any good having the shield in front (no room)...
> 
> Screenshots:
> http://www.acc.umu.se/~deepone/freeciv/engels_shields_front.png
> http://www.acc.umu.se/~deepone/freeciv/hires_shields_front.png
> 
> I was thinking that hires_shields_front should be named just
> hires_shields since I think shields with higres look really bad
> if the're not in front - so there will (should) not be another
> highres_shields... But I guess that's inconsistent... So, I'm ok
> with either naming, just thought I'd mention it...
> 
> Patch:
> http://www.acc.umu.se/~deepone/freeciv/flags_in_front2.diff.gz
> 
> tilespec file for civ2gfx updated to use the new feature:
> http://www.acc.umu.se/~deepone/freeciv/civ2gfx_shields.tilespec

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "USENET is *not* the non-clickable part of WWW!"