[Freeciv-Dev] Re: [Patch] New city dialog (10)

[Christian Knoke <ChrisK@xxxxxxxx>]

Am Donnerstag, 20. September 2001 15:28 schrieb Mike Kaufman:
> On Wed, Sep 19, 2001 at 10:05:42PM +0200, Christian Knoke wrote:
> >
> > Unit page / unit list button: When you will ever have so many
> > units in your city that you need this window (I did), you probably
> > want to select *several* units. So I'd suggest not to close
> > this window, when *one* unit is selected. Leave it open instead
> > until the user closes it.
>
> I'm not planning on doing this, since it touches code in dialogs.c I
> believe. I think this should be put on the _after inclusion_ list. I
> think though, that it should close after clicking a unit unless a
> users mods the key like Ctrl-click in order to select multiple units.

Yes, good idea, ok.

>
> > Also, could you remove the horizontal scrollbar for the available
> > items list, which appears sometimes?
>
> This is for Daniel, but are you talking about permanently removing it
> or just when it's not needed?

Permanantly. Size is not a problem any more, since the buttons
have moved below the lists.

>
> > The item sorting (straight/reverse) by clicking on the column
> > header is useless IMO. More important is a good sorting, like
> > Raimer has implemented for the city report change button. I think
> > this can be adressed after CVS inclusion.
>
> I must totally disagree. Yes, it will be better when Raimar sorts it
> alphabetically and by localization, but right now it does _not_ sort.
> It rotates between having units/city improvements/global worklists at
> the head of the list. I think that this makes global worklists far
> easier and more likely to be used.

Oh, I'm sorry. I haven't recognized how it really works :-/
Yes, is *is* usefull.

BTW: we should have more docs/help on these new functions ...
<sigh> and yes, an updated manual.

> >
> > When using up and down arrows a lot, strange things happen, i.e.
> > switching the pages irregularly.
>
> try to find a reproducible strange thing.

see my last post please.

>
> > The unit page drawing is slow. I have a 200 MHz machine, and
> > I really don't want to use it on a slower on.
>
> how many units do you have on the page?

Depends on. Ten. The more the slower.

>
> > There is still a memory hole (but smaller). Opening the dialog
> > with the units page and closing eats up approximately 100 KB
> > X ressources, according to 'ps aux | grep bin/X'.
>
> hmm
>
> -mike

Christian

-- 
* Christian Knoke                           +49 4852 92248 *
* D-25541 Brunsbuettel                  Wurtleutetweute 49 *
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.