[Freeciv-Dev] Re: [PATCH] tile_is_known()

[Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>]

On Fri, Sep 14, 2001 at 05:41:40PM +0200, Raimar Falke wrote:
> On Fri, Sep 14, 2001 at 09:49:38AM -0500, Mike Kaufman wrote:
> > +
> > +/**********************************************************************
> > + this map contains client specific map functions.
> 
> s/this map/this file/?!

heh, yes.

> 
> > + don't even think about consolidating into tilespec.c and
> 
> Why not?

the whole point of the patch, (at least for me) is to allow civworld to
use the "stock" tilespec.c in client/. Civworld needs to change
tile_is_known(), so if it's in tilespec.c, I have to "import" the whole
57k file into civworld/ to do it. That's 57k for 4 lines of changes.

> Can we put this into climisc.[ch]?

I would prefer not to. We could, but right now, climisc.c isn't being
used in civworld. I talked briefly with Ross about this issue, and if
compromise has to be made, I would add this file, and then move some of
the more map related functions is climisc.c to climap.c in a second
patch. As long as I _use_ most of the stuff that gets put into a file,
then ok.

My goal is to "reuse" as much client and server code as possible and
keep the civworld code size to a minimum. On the other hand, I don't
necessary want to include alot of object code that I'm not going to need
and drive the executable size through the roof. On the other other hand,
I want ease of maintenance. I want the thing to be robust in terms of
compilability when minor changes are made in the cvs code.

After all, people are bitching already about code size, and when and if
civworld gets included in the main tree, it'll mean a 100k increase in 
the size of the tarball...

I get the short answer is: yes I could live with this going into
climisc.c, but I think that throwing more and more crap into that file
is not good coding practice. If anything, there's probably a lot of map
code stuck in the various gui's mapview.c that could/should be put in
climap.c. (since that's code that I use in civworld, then the additional
code in climap.c just trades off with less code in mapview.c)

-mike

PS: if climap.c does go in, then obviously autoconf and automake need to
be run.