Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: [PATCH] Formatting cleanup.
Home

[Freeciv-Dev] Re: [PATCH] Formatting cleanup.

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gaute B Strokkenes <gs234@xxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] Formatting cleanup.
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 12 Sep 2001 09:10:19 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Tue, Sep 11, 2001 at 10:07:45PM +0200, Gaute B Strokkenes wrote:
> 
> This patch contains the formatting bits of the patch that I posted
> earlier containing various map coordinate related cleanups.  The
> reason I'm posting this separately is that my changing for loops to
> use iter macros is causing some very obscure and hard to track down
> changes in server behaviour (as exhibited by running a long AI game
> and comparing the save game files), so I would like to apply this ASAP
> to avoid having to drag this stuff around forever in my local tree.
> 
> Apart from that, there is a new function, nearest_real_pos().

IMHO you should have removed the formatting changes you
applied. Either don't do them or go the whole path (global indent
run). I will state my opinion more clearly the next time.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  This message has been ROT-13 encrypted twice for extra security.


[Prev in Thread] Current Thread [Next in Thread]