[Freeciv-Dev] Re: [PATCH] Formatting cleanup.

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

Gaute

There was unanimous agreement from the list that your concept of real 
map positions was badly flawed. I fail to understand why you continue
to try and apply transformations to convert unreal positions to point
at valid border tiles or any other arbitrary tile except maybe void_tile.

In addition this patch doesn't even do a comprehensive job of breaking
all the locations where it is applicable.

You have broken the implementation of normalize_map_pos by checking for
realness after having modified the coordinates.

And 90% of this is cosmetic reformats with zero code impact and negative
overall value in regions not remotely related to the changes that have any
code impact.

This is not the sort of patch I would ever expect to see from a Freeciv
maintainer. And after submitting such a patch I would not in the least
be surprised if that privilege were removed.

Cheers,
RossW
=====

At 10:07 PM 01/09/11 +0200, Gaute B Strokkenes wrote:
>
>This patch contains the formatting bits of the patch that I posted
>earlier containing various map coordinate related cleanups.  The
>reason I'm posting this separately is that my changing for loops to
>use iter macros is causing some very obscure and hard to track down
>changes in server behaviour (as exhibited by running a long AI game
>and comparing the save game files), so I would like to apply this ASAP
>to avoid having to drag this stuff around forever in my local tree.
>
>Apart from that, there is a new function, nearest_real_pos().
>
>Attachment Converted: "c:\program files\eudora\attach\formatting.diff"
>-- 
>Big Gaute                               http://www.srcf.ucam.org/~gs234/
>I hope I bought the right relish...  zzzzzzzzz...