[Freeciv-Dev] Re: [PATCH] Formatting cleanup.

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

On Sat, 15 Sep 2001, rwetmore@xxxxxxxxxxxx wrote:
> It is difficult to discuss anything with one who has some bizarre
> Clinton-esque definition of when "real" means "real". And then 
> continues in the same breath to argue why their confusion of unreal
> and border tiles is somehow justified.

I'm sorry, but you have to work harder than that to upset me.  Try
insulting my mother or something.

>>>> I fail to understand why you continue to try and apply
>>>> transformations to convert unreal positions to point at valid
>>>> border tiles or any other arbitrary tile except maybe void_tile.
>>
>>I assume you're referring to nearest_real_pos() here.  I replaced
>>calls to map_adjust_x() and map_adjust_y() with nearest_real_pos()
>>in places where I judged that the use of map_adjust_y() was used
>>deliberatly because it simplified the algorithm or whatever, rather
>>than as a broken band-aid to avoid segfaults.
> 
> If you look at the pollution changes, you have now made it policy to
> significantly increase the probability of polluting border
> tiles. I'm sure this was not the original intent of the code.

I did it like that in order not to change the behaviour of the server,
which would be out of the scope of this patch.  I don't think anyone
would complain if things were changed so that the selection is done in
a somewhat less clumsy manner, and the selection made fair.  On the
other hand, I doubt that the gameplay impact is noticable, or that
anyone really cares.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
This PIZZA symbolizes my COMPLETE EMOTIONAL RECOVERY!!