[Freeciv-Dev] Re: [PATCH] Formatting cleanup.

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 04:57 AM 01/09/14 +0200, Gaute B Strokkenes wrote:
>On Thu, 13 Sep 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
>> On Wed, Sep 12, 2001 at 11:07:46PM -0400, Ross W. Wetmore wrote:
>>> Gaute
>>> 
>>> There was unanimous agreement from the list that your concept of
>>> real map positions was badly flawed.
[...]
>Off course, this is all off-topic since my patch doesn't touch on
>anything called "real".

It is difficult to discuss anything with one who has some bizarre
Clinton-esque definition of when "real" means "real". And then 
continues in the same breath to argue why their confusion of unreal
and border tiles is somehow justified.

>>> I fail to understand why you continue to try and apply
>>> transformations to convert unreal positions to point at valid
>>> border tiles or any other arbitrary tile except maybe void_tile.
>
>I assume you're referring to nearest_real_pos() here.  I replaced
>calls to map_adjust_x() and map_adjust_y() with nearest_real_pos() in
>places where I judged that the use of map_adjust_y() was used
>deliberatly because it simplified the algorithm or whatever, rather
>than as a broken band-aid to avoid segfaults.  

If you look at the pollution changes, you have now made it policy to
significantly increase the probability of polluting border tiles. I'm 
sure this was not the original intent of the code.

[...]
>-- 
>Big Gaute                               http://www.srcf.ucam.org/~gs234/
>After this, I'm going to BURN some RUBBER!!

Cheers,
RossW
=====