[Freeciv-Dev] Re: identifier length (was: Pop cost patch (resending via bug system) (PR#897))

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Aug 24, 2001 at 01:13:13AM +0100, Vasco Alexandre Da Silva Costa wrote:
> On Fri, 24 Aug 2001, Reinier Post wrote:
> 
> > On Thu, Aug 23, 2001 at 09:24:54PM +0200, Raimar Falke wrote:
> > 
> > > It looks like the arguments "make the code ugly and harder to follow"
> > > are personal and I have learned I would have a very hard to convince
> > > you. 
> > 
> > "Names ought to be descriptive.  Names are expected to be so good that
> > the programmer will understand the code without any comments."
> > This is what we were taught in out introductory [rogramming classes
> > in computer science, and I have never found reason to disagree with it.
> > The code will be read much much more often than it is written.
> 
> And here is what i learned in Human/Machine interface class:
> 
> * buttons shouldn't be too small so they can be easily clicked on.

I also learned this in my Human/Computer interaction class.

> * buttons shouldn't be horrendously big so people don't get an arm/wrist
>   disability to click on a button. Besides this wastes screen real estate.

Same.

> * button labels should be short and meaningful.

This holds true for the english version. At least the German one has
longer names. I'm not sure if this is the language or the translators.

> We can make button sizes more dynamic in some places.
> I find button labels with >20 chars and/or multiple lines a sign of a
> poorly chosen string. I know its hard to come up with good strings but it
> certainly isn't impossible.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  reality.sys corrupt. Reboot Universe? (y,n,q)