Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)

[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Arien Malec <arien_malec@xxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 29 Aug 2001 11:43:01 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Mon, Aug 27, 2001 at 11:58:50AM -0700, Arien Malec wrote:
> Attached is the final (hopefully) version of the pop cost patch. After this,


I found only one bug:
+    {
+      char *us = get_units_with_flag_string(F_CITIES);
                                             ^^^^^^^^ This should be 
+      if (us) {
+       notify_player_ex(pplayer, punit->x, punit->y, E_NOEVENT,

> perhaps I'll take a try at factoring server/cityturn.c:city_build_stuff which
> must be one of the ugliest function in Freeciv!

Such cleanup is always welcome.


 email: rf13@xxxxxxxxxxxxxxxxx
 checking for the vaidity of the Maxwell laws on this machine... ok
 checking if e=mc^2... ok
 checking if we can safely swap on /dev/fd0... yes
    -- kvirc 2.0.0's configure 

[Prev in Thread] Current Thread [Next in Thread]