[Freeciv-Dev] Re: Map coordinate cleanups.

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 04:57 PM 01/08/16 -0400, Jason Dorje Short wrote:
>Gaute B Strokkenes wrote:
>There is a _lot_ of work ahead before an isometric map
>would be possible (although I'm not too worried about is_real_tile; it's
>only one line).  The biggest problem is replacing all map_adjust_[xy]
>macro uses with normalize_map_pos (or whatever macro you come up with to
>replace it).

Yes on both counts. 

But I think that the first stage, to get everything into a standard form
for the rectangular coordinates, is a big step forward and will really make
the second one a simple exercise. 

Note, map_adjust_* is disappearing rapidly throughout the codebase, and is
pretty much only left in special checked cases. If you run with a
corecleanup5b flavour it will do a divide by zero in those places that
still need to be changed.

>
>jason

Aside:
If your naming convention and recent patch is accepted or into CVS, I will
roll it through the corecleanup stuff on the next update. These cosmetic
changes are a pain, but it was expected pain as any 5 developers in a room
will have 6 strongly entrenched positions on such things :-). 

Cheers,
RossW