[Freeciv-Dev] Re: Map coordinate cleanups.

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> normalized positions? For the remaining 5% I don't care if the code
> is:
> 
>    x1=x+dx;
>    y1=y+dy;
>    if(!is_real_position(x1,y1))
>       continue;
>    normalize_position(&x1,&y1);
>    return (x1 and y1);
> 
> or
> 
>    x1=x+dx;
>    y1=y+dy;
>    normalize_position(&x1,&y1);
>    if(!is_real_position(x1,y1))
>       continue;
>    return (x1 and y1);
> 
> The first one looks better from a performance point of view.

Actually I vote for

    x1=x+dx;
    y1=y+dy;
    if(!normalize_position(x1,y1))
       continue;
    return (x1 and y1);

since normalize returns a very useful value.
 
Anyway, Raimar, what is this thing "AI client" that Ross mentioned
you were writing?

Best,
G.


____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie