[Freeciv-Dev] Re: Map coordinate cleanups.

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Aug 19, 2001 at 02:27:42PM +0100, Gregory Berkolaiko wrote:
>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > normalized positions? For the remaining 5% I don't care if the code
> > is:
> > 
> >    x1=x+dx;
> >    y1=y+dy;
> >    if(!is_real_position(x1,y1))
> >       continue;
> >    normalize_position(&x1,&y1);
> >    return (x1 and y1);
> > 
> > or
> > 
> >    x1=x+dx;
> >    y1=y+dy;
> >    normalize_position(&x1,&y1);
> >    if(!is_real_position(x1,y1))
> >       continue;
> >    return (x1 and y1);
> > 
> > The first one looks better from a performance point of view.
> 
> Actually I vote for
> 
>     x1=x+dx;
>     y1=y+dy;
>     if(!normalize_position(x1,y1))
>        continue;
>     return (x1 and y1);
> 
> since normalize returns a very useful value.

IMHO the first solution is the cleanest. However as I said, _I_ don't
care about the 5% which uses such methods.

> Anyway, Raimar, what is this thing "AI client" that Ross mentioned
> you were writing?

I have mail.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx