[Freeciv-Dev] Re: Corecleanup patch updates

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 12:24 PM 01/08/13 +0200, Thue wrote:
>On Sunday 12 August 2001 02:56, Gaute B Strokkenes wrote:
>> I do not like your change to the map coordinate stuff.  The basic
>> idea is sound, but the implementation is far too complicated.
>
>I don't like the coordinate optimizations to much either; sure they 
>make things a little faster by saving a "*" and a "+" in map_get_tile, 
>but they also break the modularity, making the code dependent on 
>knowing the details of the underlying implementation.
>
>In any case, I recomment you start by taking the parts of his patches 
>that you agree with immediately and apply them.
>Then the rest will be smaller and more concentrated, and you can decide 
>on them later.
>
>-Thue

Just make sure you understand the implications of what gets left out :-)

Partial selection can break things really badly if you don't get a
consistent subset of changes.

But the USE_MAP_FUNCTION optimizations should be all replacable given you 
take the corresponding map.c function changes. They aren't as heavily
tested though.

I'd actually recommend running a separate version by applying the patches
against a fresh 1.12.0 for a few days. Argue about the pieces that should
and shouldn't go in, and do a comprehensive update against current CVS in a
week or so.

Cheers,
RossW