[Freeciv-Dev] Re: [FreeCiv-Cvs] thue: When setting a ruleset filename in the server,...

[Reinier Post <rp@xxxxxxxxxx>]

On Mon, Aug 13, 2001 at 08:21:02AM -0700, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> This is an automated notification of a change to freeciv cvs, 
> on Mon Aug 13 08:13:35 PDT 2001 = Mon Aug 13 15:13:35 2001 (GMT)
> by Thue Janus Kristensen <thue@xxxxxxx>
> 
> ---- Files affected:
> 
> freeciv/client helpdata.c tilespec.c
> freeciv/common registry.c shared.c
> freeciv/server ruleset.c ruleset.h stdinhand.c
> 
> ---- Log message:
> 
> When setting a ruleset filename in the server, check that the
> file exists. (via the set command function hook).
> 
> Patch by Reinier Post <rp@xxxxxxxxxx>

This means the "/set techs 0" bug is gone.
But please be aware of the following deficiencies:

1: no check is made on the initial ruleset files
or those specified in scenarios and savegames.
(This would be easy to add.)

2: the check attempts to open the ruleset files for reading, but it
doesn't try to parse and verify them.  If a readable, but invalid
ruleset file is supplied, the server will still crash on /start,
without suitable notification to the users.  (Repairing this is
a lot of work.)

-- 
Reinier