[Freeciv-Dev] Re: Corecleanup patch updates

[Thue <thue@xxxxxxx>]

On Sunday 12 August 2001 02:56, Gaute B Strokkenes wrote:
> I do not like your change to the map coordinate stuff.  The basic
> idea is sound, but the implementation is far too complicated.

I don't like the coordinate optimizations to much either; sure they 
make things a little faster by saving a "*" and a "+" in map_get_tile, 
but they also break the modularity, making the code dependent on 
knowing the details of the underlying implementation.

In any case, I recomment you start by taking the parts of his patches 
that you agree with immediately and apply them.
Then the rest will be smaller and more concentrated, and you can decide 
on them later.

-Thue