[Freeciv-Dev] Re: TODO

[Thue <thue@xxxxxxx>]

> > Your implementation seems nicer than having seperate x and y coordinates,
> > but it would require a lot of recoding. What I had in mind was just a
small
> > change in the bounds check of x and y at select places, requireing small
> > changes, not a recode. Though it would be nice, I don't really want to
> > commit to a rewamping of all of freeciv.
>  
> Yes, my implementation requires a lot of recoding (I'm doing it right
> now). But it can be done in steps. It just takes some typecasting
> klugdes ("(struct locus({x, y}") in some places during the transition. I
> will soon release coordinates-3 (don't report bugs in coordinates-2
> because I might already have fixed them).
> 
> Now I am:
> * Abstracting away all direct use of coordinates from the river
> generator.
> * Abstracting away the use of "x=myrand(map.xsize);y=myrand(map.ysize);"
> to
>   get a random position on the map. I'm replacing it with
>   "position = random_locus_anywhere();", which I think is more elegant.
> * More similar stuff...
> 
> > -Thue
> 
> -Erik

The problem is that to commit your patches I will have to read and test them
myself, and I do not feel I can ensure I will see it to the end. Sad but true.
(you have seen for yourself how patches are never bug-free enough to be just
commited.)

-Thue