Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2000:
[Freeciv-Dev] Re: [PATCH] Names in rulesets. (PR#559)
Home

[Freeciv-Dev] Re: [PATCH] Names in rulesets. (PR#559)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] Names in rulesets. (PR#559)
From: Erik Sigra <freeciv@xxxxxxx>
Date: Sat, 16 Sep 2000 02:38:46 -0700 (PDT)

Gaute B Strokkenes wrote:
> > > On the other hand, around line 1835 in the same file Freeciv would
> > > die with a LOG_FATAL message if the sex of a ruler title is not
> > > male or female, though I changed this to LOG_ERROR (defaulting to
> > > male) in my patch.
> >
> > In this case, anything other than "Male" or "Female" is most likely
> > probably a typo (or at least not understood by the current
> > executable), so it seems reasonable to me to issue a fatal error to
> > make the ruleset creator fix it up.
> 
> I can see your logic.  I think a fatal error is a bit harsh, though.
> And I think we ought to allow case variations.

I don't think it is too harsh considering it can be easily fixed by the ruleset 
creator. In princlple I like things that force correctness. What would case 
variations be good for?




[Prev in Thread] Current Thread [Next in Thread]