[Freeciv-Dev] Re: [PATCH] Names in rulesets. (PR#559)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

gs234@xxxxxxxxx (Gaute B. Strokkenes) wrote:
> David Pfitzner <dwp@xxxxxxxxxxxxxx> writes:
> 
> > gs234@xxxxxxxxx (Gaute B. Strokkenes) wrote:
> > 
> > > Speaking of log messages, I see that some are marked for
> > > translation, and some are not.  What is correct?
> > 
> > It generally depends whether the log message is likely to be
> > seen by a user under normal use, or only by a developer, or 
> > while debugging, or to be reported to developers, etc.
> 
> So basically, it's a judgement call, yes?

Yep.

> > >  Also, the choice of log level seems very arbitrary in places.
> > 
> > Such as?
> 
> Well, LOG_DEBUG and LOG_FATAL are obvious.  The distinction between
> LOG_NORMAL, LOG_VERBOSE and LOG_ERROR seems a bit blurred in places.
> For instance, on line 1869 in server/ruleset.c, LOG_VERBOSE is used to
> indicate that the government that a title is meant for couldn't be
> found.

Well, I can explain this one.  This is so that we can use the same
nation ruleset files with different government rulesets
(default/civ1/civ2) even if the government (eg, Fundamentalism) does
not exist in some of the rulesets.  This is ok since the government
here is mainly just a suggestion for the AI.  There is something
similar for the tech and wonder suggestions.

> On the other hand, around line 1835 in the same file Freeciv would die
> with a LOG_FATAL message if the sex of a ruler title is not male or
> female, though I changed this to LOG_ERROR (defaulting to male) in my
> patch.

In this case, anything other than "Male" or "Female" is most likely
probably a typo (or at least not understood by the current
executable), so it seems reasonable to me to issue a fatal error to
make the ruleset creator fix it up.

-- David