[Freeciv-Dev] Re: [PATCH] Names in rulesets. (PR#559)

[gs234@xxxxxxxxx (Gaute B. Strokkenes)]

David Pfitzner <dwp@xxxxxxxxxxxxxx> writes:

> gs234@xxxxxxxxx (Gaute B. Strokkenes) wrote:
> 
> > Speaking of log messages, I see that some are marked for
> > translation, and some are not.  What is correct?
> 
> It generally depends whether the log message is likely to be
> seen by a user under normal use, or only by a developer, or 
> while debugging, or to be reported to developers, etc.

So basically, it's a judgement call, yes?

> >  Also, the choice of log level seems very arbitrary in places.
> 
> Such as?

Well, LOG_DEBUG and LOG_FATAL are obvious.  The distinction between
LOG_NORMAL, LOG_VERBOSE and LOG_ERROR seems a bit blurred in places.
For instance, on line 1869 in server/ruleset.c, LOG_VERBOSE is used to
indicate that the government that a title is meant for couldn't be
found.

On the other hand, around line 1835 in the same file Freeciv would die
with a LOG_FATAL message if the sex of a ruler title is not male or
female, though I changed this to LOG_ERROR (defaulting to male) in my
patch.  It seems to me that these are errors of similar magnitude, and
that Freeciv should handle them in a similar manner (by changing the
LOG_VERBOSE to a LOG_ERROR.)

The line numbers refer ruleset.c with my patch applied, btw.

-- 
Big Gaute (not to be confused with LG)
I want you to organize my PASTRY trays...  my TEA-TINS are gleaming in
 formation like a ROW of DRUM MAJORETTES --
 please don't be FURIOUS with me --