[Freeciv-Dev] Re: [PATCH] Names in rulesets. (PR#559)

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

David Pfitzner <dwp@xxxxxxxxxxxxxx> writes:

> gs234@xxxxxxxxx (Gaute B. Strokkenes) wrote:
> > David Pfitzner <dwp@xxxxxxxxxxxxxx> writes:
> > 
> > Well, LOG_DEBUG and LOG_FATAL are obvious.  The distinction between
> > LOG_NORMAL, LOG_VERBOSE and LOG_ERROR seems a bit blurred in places.
> > For instance, on line 1869 in server/ruleset.c, LOG_VERBOSE is used to
> > indicate that the government that a title is meant for couldn't be
> > found.
> 
> Well, I can explain this one.  This is so that we can use the same
> nation ruleset files with different government rulesets
> (default/civ1/civ2) even if the government (eg, Fundamentalism) does
> not exist in some of the rulesets.

That makes sense.  Thanks.

> > On the other hand, around line 1835 in the same file Freeciv would
> > die with a LOG_FATAL message if the sex of a ruler title is not
> > male or female, though I changed this to LOG_ERROR (defaulting to
> > male) in my patch.
> 
> In this case, anything other than "Male" or "Female" is most likely
> probably a typo (or at least not understood by the current
> executable), so it seems reasonable to me to issue a fatal error to
> make the ruleset creator fix it up.

I can see your logic.  I think a fatal error is a bit harsh, though.
And I think we ought to allow case variations.

-- 
Big Gaute (not to be confused with LG)
If this is the DATING GAME I want to know your FAVORITE PLANET!  Do I
 get th' MICROWAVE MOPED?