[freeciv-ai] Re: [Freeciv-Dev] (PR#9886) better AI unit assert
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://rt.freeciv.org/Ticket/Display.html?id=9886 >
Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9886 >
> On Tue, 31 Aug 2004, Jason Short wrote:
>>>>But can't you get this information from the backtrace anyway?
>>>Err, no. That's the _point_. The role is usually set much earlier than the
>>>assert. Sometimes in the turn before or several turns earlier (for
>>Um, what? It's still in the unit struct which is easily visible.
>>Although I misspoke when I said "from the backtrace", I meant "in the
> Oh. So you suggest that I keep the part of the patch that adds this info
> to the unit struct, but drop the special assert? That's not a dumb idea.
> It makes the patch only half as ugly.
You mean the ai_role_file and ai_role_line data? That could work...
However ai_role_file should be a const char * not a char[MAX_LEN_NAME].