Complete.Org: Mailing Lists: Archives: freeciv-ai: November 2002:
[freeciv-ai] Re: ripped out active diplomats patch...

[freeciv-ai] Re: ripped out active diplomats patch...

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Per I. Mathisen" <per@xxxxxxxxxxx>
Cc: freeciv-ai@xxxxxxxxxxx
Subject: [freeciv-ai] Re: ripped out active diplomats patch...
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Fri, 8 Nov 2002 18:07:45 +0000 (GMT)

On Thu, 7 Nov 2002, Per I. Mathisen wrote:

> On Thu, 7 Nov 2002, Gregory Berkolaiko wrote:
> > I don't think I can say anything now, but I printed it out and will read
> > and comment during the weekend I hope.
> >
> > One question: in ai_diplomat_city, you have
> > if (pplayer->ai.control) {
> > gold_avail -= est.upkeep
> > }
> >
> > later you also (effectively) subtract upkeep.
> >
> > Is this intended? How you picture the situation when pplayer is not
> > under AI control?
> No, this was not intentional. It may have a positive effect, however,
> since ai.est_upkeep is a small value, usually, and not having the AI bleed
> itself completely dry is a good thing.

Yep but then it should be made in one place and properly commented.  I 
actually had a few other isuues with the code, so please don't hurry with 
the inclusion.

One of the issues is mess in LOG levels distribution (or at least I 
percieve it as mess).


[Prev in Thread] Current Thread [Next in Thread]