Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2005:
[Freeciv-Dev] Re: (PR#14449) Citystyle names should use Q_() macro
Home

[Freeciv-Dev] Re: (PR#14449) Citystyle names should use Q_() macro

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: evyscr@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#14449) Citystyle names should use Q_() macro
From: "Daniel Markstedt" <himasaram@xxxxxxxx>
Date: Fri, 25 Nov 2005 18:33:31 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14449 >


2005-11-26 kl. 10.25 skrev Jason Short:

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14449 >
>
> I reverted this patch.  I'm not sure what the problem is...I guess some
> code support will be needed, or more places need to be changed to use
> the Q_?: form.
>
> -jason
>
> 

I'm sorry I neglected testing. Will be more careful from now on.

Adding ?citystyle: to the 'replaced_by' lines lets the rulesets load. 
However, since the names of city styles has in fact changed, no nation 
ruleset can find it's city style and gives as warning message:

2: Nation ?plural:Georgians: city style European is unknown, using 
default.

All defaults to European in the end. Adding ?citystyle: to the 
'city_style' line in nation rulesets solves that problem, but every 
nation ruleset has to be edited.

Yet another problem is that the ?citystyle: part somehow doesn't get 
cut from the string and shows up on the (GTK2) nation selection dialog. 
Ugly. The same happends when putting for example a ?nation: qualifier 
on Babylonian nation to solve it that way. Bug?

-Daniel





[Prev in Thread] Current Thread [Next in Thread]