[Freeciv-Dev] Re: (PR#14449) Citystyle names should use Q_() macro

["Daniel Markstedt" <himasaram@xxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14449 >


2005-11-28 kl. 22.13 skrev Christian Knoke:

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14449 >
>
> Daniel Markstedt wrote on Nov 28, 03:02 (-0800):
>> 2005-11-28 kl. 18.42 skrev Christian Knoke:
>> To add qualifiers to every single group is just too much work to
>> implement and maintain (several hundred occations.) Unless some kind
>> and skilled programmer devise another syntax for defining groups, of
>> course.
>
> Not being a skilled programmer, the attached script and diff adds a
> '?group:' qualifier to all groups in the nation rulesets. gettext is
> sensible enough to keep all translations while adding a fuzzy mark.
>
> Please check whether I got the diff right before applying.
>
>> Even if we go with qualifiers instead, what do you think about the 
>> name
>> change of Babylonian city style to Mesopotamian? More neutral, IMHO.
>
> I can provide the same for city_style. But I just notice that the 
> styles
> aren't marked for translation in the nation rulesets, so it is probably
> enough to add the qualifier in the data/*/cities.ruleset files?
>
> Christian
>

You still need to add the qualifier to city styles in all rulesets 
since the game checks for that specific string when matching city 
styles. Otherwise all nations default to 'European'.

I still don't like this solution since it adds complexity to every 
current and future nation rulesets.

-Daniel