[Freeciv-Dev] Re: (PR#2327) GUI problem with choosing government

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2327 >

On Sun, 22 Aug 2004, Jason Short wrote:
> > > This happened to a game-mate recently:
> > >
> > > While chatting, the "choose government" popup appears, and grabs
> > > the keystrokes. A <space> or <return> chooses Despotism.
> > >
> > > An expensive and frustrating mistake.
...
> > Nothing involving the government happens until the end of the turn.So
> > until the turn ends it should be possible to choose a new government
> > without returning to anarchy.
>
> Here is a patch that implements this.

I think this is totally unnecessary. In the GTK2 client, there is a new
way of choosing government that removes the need for any popups. Just go
into the menu, choose which government you want, and it will be chosen
when anarchy is over.

This could be ported back to the GTK1 instead of the nasty hack Jason
posted.

I also think we should eventually remove the popup option. As the example
above amply demonstrates, popups are inherently evil.

  - Per