[Freeciv-Dev] Re: (PR#2327) GUI problem with choosing government

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2327 >

Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=2327 >
> 
> On Sun, 22 Aug 2004, Jason Short wrote:
> 
>>>>This happened to a game-mate recently:
>>>>
>>>>While chatting, the "choose government" popup appears, and grabs
>>>>the keystrokes. A <space> or <return> chooses Despotism.
>>>>
>>>>An expensive and frustrating mistake.
> 
> ...
> 
>>>Nothing involving the government happens until the end of the turn.So
>>>until the turn ends it should be possible to choose a new government
>>>without returning to anarchy.
>>
>>Here is a patch that implements this.
> 
> 
> I think this is totally unnecessary. In the GTK2 client, there is a new
> way of choosing government that removes the need for any popups. Just go
> into the menu, choose which government you want, and it will be chosen
> when anarchy is over.
> 
> This could be ported back to the GTK1 instead of the nasty hack Jason
> posted.

The problem is the menu-selection system is itself ugly.  Just take a 
look at the packhand code for this.  The problem is it's built on top of 
the current system which isn't designed to support it.

My point is that the method proposed is cleaner than the current method IMO.

> I also think we should eventually remove the popup option. As the example
> above amply demonstrates, popups are inherently evil.

It's also not possible to remove the old-style selection method entirely 
because you may not have already researched the target government when 
you revolt.  You may get it from a teammate or ally later, possibly even 
on the turn when the revolution ends.

However if you could change governments without penalty in the turn when 
the revolution concludes, this is no longer a problem.  Then the popup 
can be removed since there is no longer a pressing need to choose the 
government.

jason