[Freeciv-Dev] Re: (PR#2327) GUI problem with choosing government

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2327 >

On Mon, 23 Aug 2004, Jason Short wrote:
> > I think this is totally unnecessary. In the GTK2 client, there is a new
> > way of choosing government that removes the need for any popups. Just go
> > into the menu, choose which government you want, and it will be chosen
> > when anarchy is over.
...
> The problem is the menu-selection system is itself ugly. Just take a
> look at the packhand code for this.

Do you mean that
1) the user interface concept of choosing the government in advance is
ugly, or that
2) the code for said user interface concept is ugly?

If it is the latter, then clearly the solution is to improve the code, not
introduce additional rules.

> The problem is it's built on top of the current system which isn't
> designed to support it.

Then one solution is to remove the old popup-system, as I suggested.

> It's also not possible to remove the old-style selection method entirely
> because you may not have already researched the target government when
> you revolt. You may get it from a teammate or ally later, possibly even
> on the turn when the revolution ends.

So? That does not mean it is not _possible_. It is just slightly
inconvenient gamewise (not UI-wise) in a few rare cases. On the other
hand, it is fair, simple and intuitive.

> However if you could change governments without penalty in the turn when
> the revolution concludes, this is no longer a problem. Then the popup
> can be removed since there is no longer a pressing need to choose the
> government.

Then players will complain that they missed the ultraimportant server
notice that revolution is over and that they want to be able to change
government any turn after as long as they haven't made the choice.

  - Per