[Freeciv-Dev] (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

I ran valgrind on the server.  Here are some of the errors I got.

==31709== Conditional jump or move depends on uninitialised value(s)
==31709==    at 0x8120BF3: send_packet_ruleset_building_100
(packets_gen.c:25949)
==31709==    by 0x81217DA: send_packet_ruleset_building
(packets_gen.c:26239)
==31709==    by 0x8121844: lsend_packet_ruleset_building
(packets_gen.c:26247)
==31709==    by 0x809BBDC: send_ruleset_buildings (ruleset.c:2904)
==31709==    by 0x809CD25: send_rulesets (ruleset.c:3245)
==31709==    by 0x80512D2: srv_loop (srv_main.c:1582)
==31709==    by 0x8051183: srv_main (srv_main.c:1525)
==31709==    by 0x804A5DE: main (civserver.c:161)

This means an important value in the packet is not being initialized.


==31709== Conditional jump or move depends on uninitialised value(s)
==31709==    at 0x813AC33: ai_manage_buildings (aicity.c:392)
==31709==    by 0x813BE56: ai_manage_cities (aicity.c:828)
==31709==    by 0x8140665: ai_do_last_activities (aihand.c:384)
==31709==    by 0x804F3D2: end_phase (srv_main.c:532)
==31709==    by 0x8050FCE: main_loop (srv_main.c:1448)
==31709==    by 0x8051818: srv_loop (srv_main.c:1761)
==31709==    by 0x8051183: srv_main (srv_main.c:1525)
==31709==    by 0x804A5DE: main (civserver.c:161)

This is just a random AI bug, but I suspect it relates to the AI changes
per made in this patch.  Looks like ai.next_recalc isn't initialized.


After that I was overwhelmed with autosettler messages.  These will need
some scrutiny separately.

After playing a few turns and building a few buildings I exited the
game.  I was overwhelmed with invalid write errors and memory leak
messages, but none seem to be related to the effects patch.

jason