[Freeciv-Dev] (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

I think find_eff_group should return a pointer to the group. 
ruleset_cache_add should take a pointer to a group.  Groups should be
sent to the client by name, not by ID.  Doing it by ID assumes that the
eff code in server and client works exactly the same way...I think.

However there doesn't seem to be much documentation on this so it's hard
for me to tell what's going on.

jason