[Freeciv-Dev] (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

I'm not happy with the naming of the num_suriviving_buildings()
funciton.  For a building to survive means that it is alive - i.e., that
it hasn't been destroyed.  But for an effect to be "surviving" means it
doesn't go away if its source does.  However this function has nothing
to do with effects, it just gets the number of alive+dead (surviving and
non-surviving) buildings.

I suggest the following naming convention:

  num_buildings_{range}_{status}

where {range} = "world", "player", "continent", "city", etc.

and {status} = "alive", "total"

Alternately (perhaps better) these values could be passed in as
enumeration values.  That may work better when the sources caches become
more developed.

jason