[Freeciv-Dev] (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

player_knows_tech should be a macro, not an inline function (according
to the guidelines, I think).

However if you do add inline functions into the header files (which I am
against unless it makes a large speed difference) they should have a
prototype up in the function-declaration section.  That way the
interface and the implementation are still somewhat separated.

jason