Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] Re: (PR#8754) effects patch
Home

[Freeciv-Dev] Re: (PR#8754) effects patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#8754) effects patch
From: "Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>
Date: Wed, 4 Aug 2004 12:52:58 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Wed, 4 Aug 2004, Jason Short wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>
> And these variables:
>
> common/improvement.h:extern int B_CAPITAL_CITY, B_LAND_DEFEND;
>
> shouldn't be all-capitalized (they are variables, not macros), nor do
> they need a B_ prefix.  And we really don't need more global variables.
>  They should just be added to the game struct as game.palace_building
> and game.land_defend_building.

There are plenty of global variables already, but I'm ok with moving them,
makes no difference to me.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa




[Prev in Thread] Current Thread [Next in Thread]