[Freeciv-Dev] Re: (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Thu, 5 Aug 2004, Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>
> In this function:
>
> +/**************************************************************************
> +  Returns the effect sources of this type currently active at the city.
> +**************************************************************************/
> +struct building_vector get_city_bonus_sources(const struct city *pcity,
> +                                             enum effect_type eff)
...
>
> memory is allocated, since a building vector is basically a pointer.  It
> must later be freed (presumably by the caller) via building_vector_free.
>  I doubt this is done (I didn't check), but even if it is this must be
> documented in the header.

Oh yes, that is most certainly done in the patch. Do you think you are
dealing with a begginer or what?

Just kidding! Memory leaks happen, but not in this case.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa