[Freeciv-Dev] Re: (PR#8754) effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
> 
> Bugs:
>  - for Prod_Add_Tile, I added this to Richards
> -    { "eff", "value"
> +    { "eff", "value", "req_type", "req"
>        "Prod_Add_Tile", 1
> +      "Prod_Add_Tile", 1, "Gov", "Monarchy"
>      }
>    and the sum total (production bonus) was updated as it should, but the
>    tiles in the city dialog only showed the first bonus, not the second.

Works fine for me.  See attached image.

However the city-center-tile-minimum is applied _after_ the richards 
bonus.  So if you build a city on grassland (no resources), the city 
center gets 1 shield.  Build richard's crusade there and the city center 
still gets 1 shield.  The attached image shows that too (but note 
richard's is giving +2 shields to all tiles).

jason